Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove page-specific font example from docs #34694

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

kara
Copy link
Collaborator

@kara kara commented Feb 22, 2022

The Font Optimization docs have an outdated example that recommends
adding fonts via next/head. This is an anti-pattern that Next.js
has already warned about through ESLint for a while (see
https://nextjs.org/docs/messages/no-page-custom-font) and is now
starting to warn about through the console because it won't work
well with streaming architecture.

This change removes the outdated example from the docs.
Fixes #34693

Documentation / Examples

  • Make sure the linting passes by running yarn lint

The Font Optimization docs have an outdated example that recommends
adding fonts via `next/head`. This is an anti-pattern that Next.js
has already warned about through ESLint for a while (see
https://nextjs.org/docs/messages/no-page-custom-font) and is now
starting to warn about through the console because it won't work
well with streaming architecture.

This change removes the outdated example from the docs.
Fixes vercel#34693
@ijjk ijjk added area: documentation created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora labels Feb 22, 2022
@kara kara marked this pull request as ready for review February 22, 2022 22:58
@kodiakhq kodiakhq bot merged commit b3f2b38 into vercel:canary Feb 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documented use of Google Fonts via next/head generates a warning in development mode
3 participants